Support usr-merged root filesystems - #2485
Closed
Dominic Ayre (DomAyre) wants to merge 1 commit into
Closed
Conversation
Dominic Ayre (DomAyre)
force-pushed
the
domayre/usr-merged-fs
branch
from
November 17, 2025 15:21
b27efae to
e0fed7f
Compare
Signed-off-by: Dominic Ayre <dominicayre@microsoft.com>
Dominic Ayre (DomAyre)
force-pushed
the
domayre/usr-merged-fs
branch
from
November 21, 2025 17:01
e0fed7f to
105f41d
Compare
Hamza El-Saawy (helsaawy)
requested changes
Nov 26, 2025
| rm -rf rootfs | ||
| mkdir -p rootfs/bin/ | ||
| rm -rf /tmp/base-rootfs && mkdir -p /tmp/base-rootfs | ||
| tar -xf $(BASE) -C /tmp/base-rootfs |
Contributor
There was a problem hiding this comment.
can we just extract the directories we need here, and not the entire filesystem?
Suggested change
| tar -xf $(BASE) -C /tmp/base-rootfs | |
| tar -xf $(BASE) -C /tmp/base-rootfs --no-anchored --no-recursion bin |
Member
|
Hi Dominic Ayre (@DomAyre) , Hamza El-Saawy (@helsaawy) This PR is still required for azurelinux builds to work. Can we get it merged to main after making the suggested changes? |
Tingmao Wang (micromaomao)
added a commit
to micromaomao/hcsshim
that referenced
this pull request
Jun 18, 2026
Without this UVM built with this Makefile doesn't boot when using Azure Linux rootfs. This is a new version of microsoft#2485 Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
Member
|
Updated in #2781 |
Tingmao Wang (micromaomao)
added a commit
to micromaomao/hcsshim
that referenced
this pull request
Jul 2, 2026
Without this UVM built with this Makefile doesn't boot when using Azure Linux rootfs. This is a new version of microsoft#2485 Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
Tingmao Wang (micromaomao)
added a commit
to micromaomao/hcsshim
that referenced
this pull request
Jul 2, 2026
Without this UVM built with this Makefile doesn't boot when using Azure Linux rootfs. This is a new version of microsoft#2485 Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
Tingmao Wang (micromaomao)
added a commit
to micromaomao/hcsshim
that referenced
this pull request
Jul 2, 2026
Without this UVM built with this Makefile doesn't boot when using Azure Linux rootfs. This is a new version of microsoft#2485 Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
Maksim An (anmaxvl)
pushed a commit
that referenced
this pull request
Jul 2, 2026
Without this UVM built with this Makefile doesn't boot when using Azure Linux rootfs. This is a new version of #2485 Signed-off-by: Dominic Ayre <dominicayre@microsoft.com> Co-authored-by: Tingmao Wang <tingmaowang@microsoft.com> Assisted-by: GitHub-Copilot Signed-off-by: Tingmao Wang <tingmaowang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some linux distros, such as AzureLinux, are usr-merged meaning that binaries are not where containerplat will expect them to be. This means we need to create symlinks from the usr directory to /bin.
How
When constructing delta.tar.gz, detect if the input rootfs is usr merged, if it isn't, keep the existing behaviour, otherwise create /usr/bin instead of /bin and then symlink.