[TESTING] nested turin fix - #4151
Open
Trevor Jones (tjones60) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Flowey-generated CI/check-in gates so the x64-windows-amd VMM tests run on a Turin nested self-hosted Windows runner, aligning the CI environment with the hardware needed to validate the reported nested virtualization bugcheck behavior.
Changes:
- Switch the
x64-windows-amdGitHub runner selection from the AMD v6 1ES pool to a Turin nested self-hosted runner. - Add a new
gh_pools::windows_turin_self_hosted_nested()helper for consistent runner label selection. - Regenerate the auto-generated GitHub Actions workflows to reflect the updated
runs-onlabels.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flowey/flowey_hvlite/src/pipelines/checkin_gates.rs | Updates the Windows x64 AMD VMM test job to target the Turin nested self-hosted GH runner. |
| flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs | Adds a new GH runner pool helper for the Turin nested self-hosted runner labels. |
| .github/workflows/openvmm-pr.yaml | Regenerated workflow: updates runs-on labels for x64-windows-amd VMM tests job. |
| .github/workflows/openvmm-pr-release.yaml | Regenerated workflow: updates runs-on labels for x64-windows-amd VMM tests job. |
| .github/workflows/openvmm-ci.yaml | Regenerated workflow: updates runs-on labels for x64-windows-amd VMM tests job. |
Comment on lines
1601
to
+1603
| // a Windows hypervisor bug causes VMM tests to crash | ||
| // when running on v7, so use v6 | ||
| gh_pool: gh_pools::windows_amd_v6_1es(), | ||
| gh_pool: gh_pools::windows_turin_self_hosted_nested(), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seeing if L0 fix for turin amd hardware fixes L1 hypervisor bugcheck.