Skip to content

fix(server): use fs.promises.rm to delete temp upload directories #40755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pavelfeldman merged 1 commit into from
May 9, 2026
Merged

fix(server): use fs.promises.rm to delete temp upload directories #40755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/playwright-core/src/server/browserContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ export abstract class BrowserContext<EM extends EventMap = EventMap> extends Sdk
}

private async _deleteAllTempDirs(): Promise<void> {
await Promise.all(this._tempDirs.map(async dir => await fs.promises.unlink(dir).catch(e => {})));
await Promise.all(this._tempDirs.map(async dir => await fs.promises.rm(dir, { recursive: true, force: true }).catch(e => {})));
Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in other places dealing with tmp, we want it to be a best effort. If a leaking process holding onto one of the files, we should give up and give it a pass.

Copy link
Copy Markdown
Contributor Author

@SebTardif SebTardif May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The current code uses force: true (ignores ENOENT) and .catch(e => {}) (swallows any remaining errors like EBUSY from held files). So it is already best-effort: it cleans up what it can and silently gives up on the rest.

Copy link
Copy Markdown
Member

@pavelfeldman pavelfeldman May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there are no retries, I missed that. All good then.

}

setCustomCloseHandler(handler: (() => Promise<any>) | undefined) {
Expand Down
Loading