fix(html-reporter): add keyboard navigation to TabbedPane component#41042
Open
padmarajnidagundi wants to merge 1 commit into
Open
fix(html-reporter): add keyboard navigation to TabbedPane component#41042padmarajnidagundi wants to merge 1 commit into
padmarajnidagundi wants to merge 1 commit into
Conversation
Add WCAG 2.1 compliant keyboard navigation to TabbedPane in the HTML reporter and trace viewer. Previously, the tab components only responded to mouse clicks, preventing keyboard-only and screen reader users from navigating between tabs. - Add Arrow Right/Left to move focus between tabs - Add Home/End to jump to first/last tab - Use roving tabIndex pattern (0 for selected tab, -1 for others) Fixes microsoft#41005
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41005 — the
TabbedPanecomponent in the HTML reporter and trace viewer was missing keyboard navigation, making it inaccessible to keyboard-only users and screen readers.Changes
Both
packages/html-reporter/src/tabbedPane.tsxandpackages/web/src/components/tabbedPane.tsxnow implement the ARIA Tabs keyboard interaction pattern:ArrowRightArrowLeftHomeEndAdditionally, tabs now use the roving
tabIndexpattern — the selected tab hastabIndex={0}and all others havetabIndex={-1}, so Tab key enters the tablist at the currently-selected tab.Implementation Notes
role="tablist"container for clean event delegationdocument.activeElementto find the focused tab index, avoiding stale closure issuese.preventDefault()is called on handled keys to prevent page scroll on Arrow/Home/End keys