fix(core): show friendly error for unsupported Node.js versions#41050
Open
Skn0tt wants to merge 1 commit into
Open
fix(core): show friendly error for unsupported Node.js versions#41050Skn0tt wants to merge 1 commit into
Skn0tt wants to merge 1 commit into
Conversation
The MCP SDK code in utilsBundle.js eagerly evaluates `class Request extends global.Request`, which throws on Node <18 where `global.Request` is undefined. The CLI entry path (`playwright/cli.js` -> `lib/program` -> `playwright-core/lib/coreBundle`) does not require `playwright-core/index.js`, so the Node-version guard there never ran and users saw a cryptic `Class extends value undefined` crash instead. Move the version check into `playwright-core/lib/bootstrap`, which is already imported as the first statement of `program.ts` (and the playwright-core CLI), so it runs before any bundle is loaded. The API entry (`playwright-core/index.js`) now requires bootstrap first to preserve the same behavior. Fixes: microsoft#41045
Contributor
Test results for "MCP"7207 passed, 1113 skipped Merge workflow run. |
Contributor
Test results for "tests 1"2 flaky43984 passed, 864 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-core/lib/bootstrapso it runs beforeutilsBundleis loaded.class Request extends global.Requestwas throwingClass extends value undefinedat module load, before the existing guard inplaywright-core/index.jscould run (the CLI path doesn't require that file.Fixes #41045
EOF
)