feat(trace): split API requests into a separate network stream - #42073
Open
dcrousso wants to merge 1 commit into
Open
feat(trace): split API requests into a separate network stream#42073dcrousso wants to merge 1 commit into
dcrousso wants to merge 1 commit into
Conversation
the existing `.network` stream mixed browser traffic with `APIRequestContext` traffic record `_apiRequest` entries in `.api.network`, archive it as `trace.api.network`, and ingest it alongside `.network` bump the trace format to `9` so older viewers reject traces that have the new stream
pavelfeldman
left a comment
pavelfeldman
left a comment
Member
There was a problem hiding this comment.
On a high level, I expect the fetch context to have its own trace file and its own network file. No apiNetworkFile in the recording state/ no version bump. API request context is just another context with its own trace and network.
Contributor
Test results for "MCP"7867 passed, 1272 skipped Merge workflow run. |
Contributor
Test results for "tests 1"9 flaky51118 passed, 1188 skipped Merge workflow run. |
|
great post |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the existing
.networkstream mixed browser traffic withAPIRequestContexttrafficrecord
_apiRequestentries in.api.network, archive it astrace.api.network, and ingest it alongside.networkbump the trace format to
9so older viewers reject traces that have the new stream