Skip to content

fix(mcp): only enable /killkillkill under test - #42133

Open
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-42129-remove-killkillkill
Open

fix(mcp): only enable /killkillkill under test#42133
Skn0tt wants to merge 1 commit into
microsoft:mainfrom
Skn0tt:skn0tt-fix-42129-remove-killkillkill

Conversation

@Skn0tt

@Skn0tt Skn0tt commented Aug 5, 2026

Copy link
Copy Markdown
Member

/killkillkill was only meant for our graceful-SIGINT test (Windows can't do that via SIGTERM). Anyone who could reach the HTTP port could still trip it with the fixed header.

Gate it on isUnderTest() so production MCP HTTP servers don't expose it.

Fixes #42129

Fixes: microsoft#42129

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: bcb5b8bb-90b5-4bc9-baae-64ab11a9c665
@Skn0tt
Skn0tt requested a review from pavelfeldman August 5, 2026 09:58
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

1 failed
❌ [firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate @mcp-windows-latest-firefox

8049 passed, 1284 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures.

🟢 The one failure is a pre-existing flake — this PR is clear

[firefox] › mcp/annotate.spec.ts:446 › should switch screencast to -s session on show --annotate flakes on its own across the CI history, and this PR only gates the /killkillkill HTTP endpoint behind isUnderTest(), which the annotate/screencast flow never touches.

Details

Overall: one failed test, no real failures caused by this PR.

Pre-existing flake / infra

Triaged by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: MCP HTTP clients can terminate the server through /killkillkill

1 participant