Use MSTest.Sdk in packaged WinUI acceptance coverage - #10511
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9f87d322-bbca-4e55-bb3f-43bdde92cc24
There was a problem hiding this comment.
Pull request overview
Migrates packaged WinUI acceptance coverage to the consumer-facing MSTest.Sdk flow. It also temporarily carries #10491’s AppContainer pipe-authorization implementation, plus unrelated GitHub Actions and glossary changes.
Changes:
- Uses the SDK-generated MTP helper and verifies resolved WinUI assets/settings.
- Adds AppContainer SID derivation and controller-pipe authorization.
- Adds unrelated GitHub Actions option validation and glossary entries.
Show a summary per file
| File | Description |
|---|---|
test/UnitTests/Microsoft.Testing.Platform.UnitTests/IPC/NamedPipeServerSecurityTests.cs |
Tests pipe ACL security behavior. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/PackagedAppPipeAuthorizationTests.cs |
Tests packaged-app authorization decisions. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/GitHubActionsCommandLineProviderTests.cs |
Tests report sub-option validation. |
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/AppContainerSecurityIdentifierTests.cs |
Tests package SID derivation. |
test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/PackagedWinUITests.cs |
Migrates WinUI asset to MSTest.Sdk. |
src/Platform/Microsoft.Testing.Platform/TestHostControllers/ITestHostControllerConnectionAuthorizer.cs |
Adds authorization extension contract. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf |
Adds localized resource placeholder. |
src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx |
Adds invalid-identity error text. |
src/Platform/Microsoft.Testing.Platform/PublicAPI/PublicAPI.Unshipped.txt |
Tracks the new public contract. |
src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServerSecurity.cs |
Implements explicit Windows pipe ACLs. |
src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs |
Accepts authorized identities. |
src/Platform/Microsoft.Testing.Platform/InternalAPI/InternalAPI.Unshipped.txt |
Tracks new internal constructors. |
src/Platform/Microsoft.Testing.Platform/Hosts/TestHostControllersTestHost.cs |
Requests authorization before pipe creation. |
src/Platform/Microsoft.Testing.Extensions.TrxReport/InternalAPI/InternalAPI.Unshipped.txt |
Tracks shared IPC constructors. |
src/Platform/Microsoft.Testing.Extensions.Retry/InternalAPI/InternalAPI.Unshipped.txt |
Tracks shared IPC constructors. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/PackagedAppTestHostLauncher.cs |
Supplies package authorization identity. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/PackagedAppExtensions.cs |
Documents the authorization hook. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/PACKAGE.md |
Documents AppContainer pipe access. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/Microsoft.Testing.Extensions.PackagedApp.csproj |
Updates package description. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/InternalAPI/InternalAPI.Unshipped.txt |
Tracks new internal APIs. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/AppxManifestInfo.cs |
Classifies AppContainer applications. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/AppxApplicationInfo.cs |
Stores AppContainer classification. |
src/Platform/Microsoft.Testing.Extensions.PackagedApp/AppContainerSecurityIdentifier.cs |
Derives package SIDs. |
src/Platform/Microsoft.Testing.Extensions.MSBuild/InternalAPI.Unshipped.txt |
Tracks shared IPC constructors. |
src/Platform/Microsoft.Testing.Extensions.HangDump/InternalAPI/InternalAPI.Unshipped.txt |
Tracks shared IPC constructors. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.zh-Hant.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.zh-Hans.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.tr.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.ru.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.pt-BR.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.pl.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.ko.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.ja.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.it.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.fr.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.es.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.de.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/xlf/GitHubActionsResources.cs.xlf |
Adds validation resource placeholder. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/Resources/GitHubActionsResources.resx |
Adds sub-option validation message. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/InternalAPI/InternalAPI.Unshipped.txt |
Tracks validation override. |
src/Platform/Microsoft.Testing.Extensions.GitHubActionsReport/GitHubActionsCommandLineProvider.cs |
Validates report sub-options. |
docs/winui-testing.md |
Documents AppContainer communication support. |
docs/RFCs/017-TestHost-Launcher.md |
Documents authorization contract and ACL. |
docs/glossary.md |
Updates PackagedApp and Server Mode entries. |
Review details
- Files reviewed: 14/87 changed files
- Comments generated: 3
- Review effort level: Balanced
1259bea to
36128a0
Compare
🧪 Expert test review — PR #10511
Only one changed test method fell inside the diff's changed line ranges; the other touched regions (the embedded This advisory comment was generated automatically. Grades are heuristic
|
🧵 Parallel-safety audit — PR #10511Nothing audited here touches process-global state, shared filesystem paths, or The single changed test file ( Audited Re-run with
|
Build the real packaged WinUI acceptance asset through
MSTest.Sdkinstead of manually assembling the MSTest runner, framework, adapter, and packaged-app launcher. This makes the end-to-end test verify the SDK experience consumers actually use.The asset now asserts that the SDK enables the MTP runner, suppresses the competing generated entry point for the WinUI
ApplicationDefinition, emits the reusable application helper, and includesMicrosoft.Testing.Extensions.PackagedApp. ItsOnLaunchedimplementation uses that generated helper directly.Depends on #10491. Until that PR merges, this PR temporarily includes its controller-pipe authorization commits in the diff against
main.