Skip to content

Split test host controller into focused partial files - #10513

Merged
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/split-test-host-controller
Aug 9, 2026
Merged

Split test host controller into focused partial files#10513
Amaury Levé (Evangelink) merged 2 commits into
mainfrom
dev/amauryleve/split-test-host-controller

Conversation

@Evangelink

Copy link
Copy Markdown
Member

Summary

  • split TestHostControllersTestHost into focused partial-class files for orchestration, process configuration, process lifecycle, IPC, and disposal
  • preserve the existing cancellation, process notification, IPC handshake, message bus, disposal, telemetry, and exit-code ordering
  • keep every partial file below 300 lines and preserve UTF-8 BOM encoding

Validation

  • Microsoft.Testing.Platform build across net8.0, net9.0, and netstandard2.0
  • Microsoft.Testing.Platform.UnitTests on net8.0, net9.0, and net462
  • 12 CoverageThresholdControllerExitCodeTests acceptance cases after packing repository packages
  • two independent behavior-regression review rounds with no high-confidence findings

Closes #10512

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 7, 2026 21:28
@Evangelink Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors TestHostControllersTestHost into focused partial-class files while preserving behavior and API shape.

Changes:

  • Separates process configuration, lifecycle, IPC, and disposal logic.
  • Retains orchestration in the primary file.
  • Keeps all files below 300 lines with UTF-8 BOM encoding.
Show a summary per file
File Description
TestHostControllersTestHost.cs Retains streamlined orchestration.
TestHostControllersTestHost.ProcessConfiguration.cs Extracts process and environment setup.
TestHostControllersTestHost.ProcessLifecycle.cs Extracts launch, lifecycle, telemetry, and exit handling.
TestHostControllersTestHost.Ipc.cs Extracts IPC creation and request handling.
TestHostControllersTestHost.Disposal.cs Extracts service and instance disposal.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 7, 2026 22:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review details

  • Files reviewed: 5/5 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@Evangelink
Amaury Levé (Evangelink) merged commit 08b17af into main Aug 9, 2026
34 checks passed
@Evangelink
Amaury Levé (Evangelink) deleted the dev/amauryleve/split-test-host-controller branch August 9, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/needs-review Awaiting review from the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[file-diet] Refactor TestHostControllersTestHost.cs (641 lines) into smaller, focused files

3 participants