Fix stale BYOK model selection after vendor resolves with zero models#318424
Draft
Copilot wants to merge 2 commits into
Draft
Fix stale BYOK model selection after vendor resolves with zero models#318424Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: vritant24 <13074644+vritant24@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix BYOK UI not resetting last model selection
Fix stale BYOK model selection after vendor resolves with zero models
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After removing BYOK models and reloading, the chat picker button kept displaying the previously selected BYOK model (e.g. "Claude Haiku 4.5") while the dropdown only listed "Auto".
Root cause
The chat input bridges the startup race by retaining cached models for vendors that haven't resolved yet (
mergeModelsWithCache), keying eviction onhasResolvedVendor. When a BYOK vendor later resolves with zero model groups (key/config removed),_modelsGroups.set(vendor, [])flipshasResolvedVendorfromfalse→true, but_resolveAllLanguageModelsdid not fireonDidChangeLanguageModelsbecause both the old and new model/group lists were empty. Consumers silently evicted the cached BYOK model from their merged view, yetresetCurrentLanguageModelIfUnavailablenever ran, so_currentLanguageModelkept pointing at the now-unavailable model.Changes
src/vs/workbench/contrib/chat/common/languageModels.ts: treat the first resolution of a vendor as a change, so the event always fires on the unresolved → resolved transition. The existing reset handler then falls back to the default model in the list (per the agent instruction on the issue).src/vs/workbench/contrib/chat/test/common/languageModels.test.ts: regression test "fires onChange event when a vendor first resolves with zero models".