Skip to content

Fix chat notification outline to match chat input focus ring#318471

Merged
dmitrivMS merged 4 commits into
mainfrom
dev/dmitriv/fix-chat-notification-outline
May 27, 2026
Merged

Fix chat notification outline to match chat input focus ring#318471
dmitrivMS merged 4 commits into
mainfrom
dev/dmitriv/fix-chat-notification-outline

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

Fixes focus outline issues reported in #318190

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings May 27, 2026 00:15
@dmitrivMS dmitrivMS self-assigned this May 27, 2026
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 27, 2026 00:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the chat input notification widget’s border styling so its outline better matches the chat input’s normal border and focus ring, addressing the focus outline inconsistency mentioned in #318190.

Changes:

  • Update the info notification’s default border color to match the input border (--vscode-input-border).
  • Add a focused-state CSS rule so the info notification border switches to --vscode-focusBorder when the chat input is focused.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/input/media/chatInputNotificationWidget.css Aligns the info notification border with the chat input’s normal and focused border appearance.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

DonJayamanne
DonJayamanne previously approved these changes May 27, 2026
@dmitrivMS dmitrivMS disabled auto-merge May 27, 2026 04:45
@dmitrivMS dmitrivMS enabled auto-merge (squash) May 27, 2026 06:12
@dmitrivMS dmitrivMS merged commit d1388f2 into main May 27, 2026
25 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/fix-chat-notification-outline branch May 27, 2026 07:40
@vs-code-engineering vs-code-engineering Bot added this to the 1.123.0 milestone May 27, 2026
@dmitrivMS dmitrivMS added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label May 27, 2026
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

model-byok release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants