Use per-action min-widths for short agent-host pickers#318502
Open
roblourens wants to merge 1 commit into
Open
Use per-action min-widths for short agent-host pickers#318502roblourens wants to merge 1 commit into
roblourens wants to merge 1 commit into
Conversation
Convert the agent-host short-picker set to a map so each picker can have its own min-width. The tunnel-sharing toggle has no chevron, so it collapses to 16px instead of 22px. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts responsive overflow behavior for the chat input’s secondary (permissions) toolbar so agent-host pickers can collapse to icon-only more aggressively, keeping them visible instead of being pushed into the overflow menu.
Changes:
- Replaces a
Set<string>of “short picker” action IDs with aMap<string, number>so each action can report its owngetActionMinWidth. - Keeps agent-host picker min-width at
22pxwhile reducingsessions.tunnelHost.toggleSharingto16px.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Introduces per-action min-widths for secondary-toolbar pickers via getActionMinWidth to improve responsive collapsing behavior. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dmitrivMS
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the chat input's secondary toolbar, agent-host pickers report a smaller
actionMinWidth(22px) so they can collapse to icon-only and stay visible instead of overflowing into the…menu. The tunnel-sharing toggle has no chevron, so 22px is still too wide — it should collapse further to 16px.getActionMinWidthonly accepts anumber | undefined, so the existingSet<string>is replaced with aMap<string, number>mapping each action id to its own min-width:sessions.tunnelHost.toggleSharing→ 16Unlisted actions fall through to the default
actionMinWidth: 48.(Written by Copilot)