Fix native MDM plugin marketplace parsing - #333822
Open
Joel Thiessen (jatjat) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes native MDM object-form plugin marketplaces being discarded during configuration parsing.
Changes:
- Preserves and names object-form managed marketplace entries.
- Adds regression coverage for Git sources and
autoUpdate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
marketplaceReference.ts |
Supports object-form policy entries. |
pluginMarketplaceService.test.ts |
Tests native MDM marketplace parsing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
@microsoft-github-policy-service agree company="Canadian Tire Corporation, Limited" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333816
Summary
Native MDM delivers structured managed settings as JSON inside an OS string. After the policy layer parses a documented object-form
extraKnownMarketplacesvalue,readConfiguredMarketplaces()silently discarded each marketplace because it accepted only string values.This change preserves object-form values, adds the marketplace dictionary key as their
name, and forwards them to the existing object parser. Existing string-map behavior remains unchanged. A focused regression test covers the native-MDM object shape, includingautoUpdate.Evidence
Why This Layer
parseMarketplaceObjectEntry()already supports the documented nested shape. Letting object values reach that parser fixes native MDM without changing policy ingestion or the canonical string-map path used by other delivery channels.Testing
npm run compile-client./scripts/test.sh --run src/vs/workbench/contrib/chat/test/common/plugins/pluginMarketplaceService.test.ts(94 passing)npm run eslint -- src/vs/workbench/contrib/chat/common/plugins/marketplaceReference.ts src/vs/workbench/contrib/chat/test/common/plugins/pluginMarketplaceService.test.ts