Sync complete skill directories to remote agent hosts - #333827
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/syncedCustomizationBundler.ts — This containment check is only lexical, so a path such as references/notes.md can still be a… |
 |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/syncedCustomizationBundler.ts — Using UTF-8 text as the nonce input loses information for linked binary files. For example, buffers… |
|
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/syncedCustomizationBundler.ts — The default rethrow means an unrecognized provider/I/O read failure (FILE_OTHER_ERROR) aborts the… |
What changed in this PR
Adds remote syncing for files linked from SKILL.md.
Changes:
- Parses inline and reference-style relative Markdown links.
- Bundles linked files with provenance and nonce invalidation.
- Adds regression coverage for supported and invalid targets.
| File | Description |
|---|---|
syncedCustomizationBundler.ts |
Resolves and bundles linked skill files. |
syncedCustomizationBundler.test.ts |
Tests link handling and updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d60c8636-9aaa-42ee-b94f-e7daba0c32aa
Paul (pwang347)
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d60c8636-9aaa-42ee-b94f-e7daba0c32aa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d60c8636-9aaa-42ee-b94f-e7daba0c32aa
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54febce8-3c95-4100-bf37-0e38cca467d1
Paul (pwang347)
marked this pull request as ready for review
September 1, 2026 21:29
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54febce8-3c95-4100-bf37-0e38cca467d1
Paul (pwang347)
enabled auto-merge (squash)
September 1, 2026 22:00
Connor Peet (connor4312)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git,node_modules, and nested symlinksSKILL.mdentry points, including symlinked entry points that worked before this changeFixes #333259