Skip to content

Fix Automation skill completion interactions - #333834

Merged
Paul (pwang347) merged 10 commits into
mainfrom
pawang/automations-skill-completions
Sep 1, 2026
Merged

Fix Automation skill completion interactions#333834
Paul (pwang347) merged 10 commits into
mainfrom
pawang/automations-skill-completions

Conversation

@pwang347

@pwang347 Paul (pwang347) commented Sep 1, 2026

Copy link
Copy Markdown
Member

Follow-up to #333669.

Fix skill completion interactions in the Automations dialog so that:

  • Tab and Enter accept a focused skill suggestion instead of being intercepted by dialog navigation or newline handling.
  • Accepted skills use the same inline reference styling as regular chat inputs.
  • Saved skill references are revalidated against the active Agent Host and highlighted again when an Automation is reopened.
  • Edited or invalid skill references lose their decoration when their text no longer matches.
  • Runtime skill completion metadata continues to be preserved end-to-end.

The shared chat reference decoration registration is extracted so regular chat and Automations use the same theme-aware styling. Automations still persists a plain prompt string rather than chat attachment state.

Validation

  • npm run transpile-client
  • Focused unit tests across Automations, chat variables, Agent Host metadata/completion mapping, and chat contribution behavior: 504 passing
  • Latest Automation interaction and persistence suite: 35 passing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Copilot AI balanced review requested due to automatic review settings September 1, 2026 18:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Balanced
Findings: 1 High severity · 1 Medium severity

New issues introduced by this change (2)
Severity Finding
High severity src/​vs/​sessions/​contrib/​automations/​browser/​automationDialog.ts — Returning here still does not let Monaco handle Tab. This listener is installed during…
Medium severity src/​vs/​sessions/​contrib/​automations/​browser/​automationInputCompletions.ts — This equality check misses edits at either edge of the reference. The decoration uses…
What changed in this PR

Updates Automations skill completion interactions and shares chat reference styling.

Changes:

  • Adjusts Tab handling when suggestions are focused.
  • Adds and maintains inline skill-reference decorations.
  • Adds focused completion and keyboard-navigation tests.
File Description
chatInputReferenceDecorations.ts Extracts shared decoration registration.
chatInputEditorContrib.ts Uses the shared decoration helper.
automationInputCompletions.ts Tracks accepted skill decorations.
automationDialog.ts Exposes suggestion state to keyboard navigation.
automationDialogService.ts Wires suggestion state into the focus trap.
automationInputCompletions.test.ts Tests completion decoration creation.
automationDialog.test.ts Tests Tab propagation with suggestions.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/sessions/contrib/automations/browser/automationDialog.ts Outdated
Comment thread src/vs/sessions/contrib/automations/browser/automationInputCompletions.ts Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
@pwang347
Paul (pwang347) marked this pull request as ready for review September 1, 2026 20:13
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 54febce8-3c95-4100-bf37-0e38cca467d1
@pwang347
Paul (pwang347) merged commit 54157b1 into main Sep 1, 2026
40 checks passed
@pwang347
Paul (pwang347) deleted the pawang/automations-skill-completions branch September 1, 2026 21:59
@vs-code-engineering vs-code-engineering Bot added this to the 1.137.0 milestone Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants