Fix Automation skill completion interactions - #333834
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 24f4e305-8042-4e9f-8061-72525532fc1b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
src/vs/sessions/contrib/automations/browser/automationDialog.ts — Returning here still does not let Monaco handle Tab. This listener is installed during… |
|
src/vs/sessions/contrib/automations/browser/automationInputCompletions.ts — This equality check misses edits at either edge of the reference. The decoration uses… |
What changed in this PR
Updates Automations skill completion interactions and shares chat reference styling.
Changes:
- Adjusts Tab handling when suggestions are focused.
- Adds and maintains inline skill-reference decorations.
- Adds focused completion and keyboard-navigation tests.
| File | Description |
|---|---|
chatInputReferenceDecorations.ts |
Extracts shared decoration registration. |
chatInputEditorContrib.ts |
Uses the shared decoration helper. |
automationInputCompletions.ts |
Tracks accepted skill decorations. |
automationDialog.ts |
Exposes suggestion state to keyboard navigation. |
automationDialogService.ts |
Wires suggestion state into the focus trap. |
automationInputCompletions.test.ts |
Tests completion decoration creation. |
automationDialog.test.ts |
Tests Tab propagation with suggestions. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: c69533f7-290b-4cfe-8863-4c2a9c43aec5
Paul (pwang347)
marked this pull request as ready for review
September 1, 2026 20:13
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Sep 1, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 54febce8-3c95-4100-bf37-0e38cca467d1
roblourens
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Follow-up to #333669.
Fix skill completion interactions in the Automations dialog so that:
The shared chat reference decoration registration is extracted so regular chat and Automations use the same theme-aware styling. Automations still persists a plain prompt string rather than chat attachment state.
Validation
npm run transpile-client