sessions: refine Agent Merge PR actions - #333835
Merged
Benjamin Christopher Simmonds (benibenj) merged 3 commits intoSep 1, 2026
Merged
sessions: refine Agent Merge PR actions#333835Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Benjamin Christopher Simmonds (benibenj) merged 3 commits into
Conversation
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 1, 2026 18:49
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 1, 2026 18:49
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/platform/agentHost/node/agentHostPullRequestOperationHandler.ts — Enabling here preserves the user overrides but also leaves any existing… |
|
src/vs/sessions/contrib/changes/browser/changesView.ts — This delegation executes the enable/disable command through a wrapper that still has the submenu's… |
What changed in this PR
Refines Agent Merge PR actions, menu behavior, and optimistic operation feedback.
Changes:
- Adds “Create PR & Enable Agent Merge.”
- Makes the primary Agent Merge action toggle enablement.
- Shows invoked operations as running until completion.
| File | Description |
|---|---|
agentMergeActions.test.ts |
Tests Agent Merge menu nesting and ordering. |
agentHostSessionChangesets.test.ts |
Tests optimistic running status. |
agentMergeActions.ts |
Reorganizes toggle and configuration actions. |
agentHostSessionChangesets.ts |
Tracks locally running operations. |
changesViewActions.test.ts |
Updates PR achievement coverage. |
sessionsChangesAccessibilityHelp.ts |
Documents the revised interaction. |
changesView.ts |
Delegates the primary submenu action. |
menus.ts |
Adds the configuration submenu. |
agentHostPullRequestOperationProvider.test.ts |
Tests operation advertisement. |
agentHostPullRequestOperationHandler.test.ts |
Tests PR creation and enablement. |
agentHostPullRequestOperationProvider.ts |
Advertises and registers the new operation. |
agentHostPullRequestOperationHandler.ts |
Enables Agent Merge after PR creation. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Base:
|
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 1, 2026
Add a combined create-PR-and-enable-Agent-Merge operation, reorganize Agent Merge configuration under a submenu, and restore immediate running feedback for changeset operations. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the strict contribution activation harness aligned with the pull request operation contribution's dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reset stale controller state when enabling Agent Merge for a newly created pull request and preserve the delegated toggle command identity in the primary button. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
force-pushed
the
benibenj/agents/create-pr-agent-merge-options
branch
from
September 1, 2026 21:01
7470188 to
fbcee5b
Compare
roblourens
approved these changes
Sep 1, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 1, 2026
ba0c096
into
main
40 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/create-pr-agent-merge-options
branch
September 1, 2026 21:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation