Agents - add commit operation into the Changes view - #333842
Merged
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Sandeep Somavarapu (@sandy081)Matched files:
|
Copilot started reviewing on behalf of
Ladislau Szomoru (lszomoru)
September 1, 2026 19:34
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Non-commit changeset actions are not scoped to the Changes editor and can appear on unrelated editor tabs.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/changes/browser/changesActions.ts — Apply the Changes-editor visibility condition to every registered changeset action. This loop… |
What changed in this PR
Adds commit support for uncommitted changes in draft Agent sessions.
Changes:
- Defines shared commit, sync, and uncommitted changeset identifiers.
- Advertises Commit for new sessions and exposes changeset operations in the Changes editor header.
- Adds accessibility guidance and focused tests.
| File | Description |
|---|---|
src/vs/sessions/services/sessions/common/session.ts |
Defines the uncommitted changeset ID. |
src/vs/sessions/contrib/changes/browser/changesActions.ts |
Registers draft-session changeset actions. |
src/vs/sessions/contrib/changes/browser/sessionsChangesAccessibilityHelp.ts |
Documents editor title-bar actions. |
src/vs/sessions/contrib/changes/test/browser/changesActions.test.ts |
Tests action registration and invocation. |
src/vs/platform/agentHost/common/agentHostChangesetOperationService.ts |
Defines shared operation IDs. |
src/vs/platform/agentHost/node/agentHostCommitOperationProvider.ts |
Advertises Commit for unused drafts. |
src/vs/platform/agentHost/node/agentHostCommitOperationHandler.ts |
Uses the shared commit ID. |
src/vs/platform/agentHost/node/agentHostSyncOperationHandler.ts |
Uses the shared sync ID. |
src/vs/platform/agentHost/test/node/agentHostCommitOperationProvider.test.ts |
Covers empty draft-session advertisement. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 1, 2026
Benjamin Christopher Simmonds (benibenj)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.