sessions: show workspace before harness picker - #333844
Merged
Merged
Conversation
Fixes #333807 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 1, 2026 19:35
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The quick-chat-to-workspace rerender path lacks regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts — This assertion covers only the initial _renderWorkspacePicker call. The other changed path… |
What changed in this PR
Reorders the new-session composer so workspace selection precedes harness selection.
Changes:
- Moves the harness picker after workspace controls.
- Updates the corresponding DOM-order assertion.
| File | Description |
|---|---|
newChatWidget.ts |
Removes harness-first DOM reordering. |
newChatWidget.test.ts |
Updates expected picker order. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Base:
|
Henning Dieterichs (hediet)
previously approved these changes
Sep 1, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333807
Orders the new-session controls as Workspace → Harness → Issue/PR, including rerenders when switching out of quick chat. The selected workspace determines the available harnesses, while Issue/PR is supplemental context. This aligns visual, keyboard, and accessibility order with the workflow.
Validation
npm run compile./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/newChatWidget.test.ts(11 passing)