Handle warning and info messages froom SDK - #333851
Merged
Merged
Conversation
Henning Dieterichs (hediet)
previously approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The notice translation and UI propagation are consistent with existing model-picker behavior and have focused test coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Propagates SDK model warnings and informational notices into the chat model picker.
Changes:
- Converts SDK notices into Agent Host metadata.
- Displays warning icons, tooltips, and notice banners.
- Adds focused propagation tests.
| File | Description |
|---|---|
agentModelNotices.ts |
Converts and validates notice metadata. |
copilotAgent.ts |
Adds notices to model metadata. |
copilotAgent.test.ts |
Tests SDK notice conversion. |
agentHostLanguageModelProvider.ts |
Exposes notices to the model picker. |
agentHostLanguageModelProvider.test.ts |
Tests picker warning presentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.