Fix assignment of mp_stacks_magnificPopup#12
Open
acurrieclark wants to merge 1 commit intomintplugins:masterfrom
Open
Fix assignment of mp_stacks_magnificPopup#12acurrieclark wants to merge 1 commit intomintplugins:masterfrom
acurrieclark wants to merge 1 commit intomintplugins:masterfrom
Conversation
Owner
|
@acurrieclark Thanks for the PR! I haven't experienced this, but I will test it out asap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to edit any of the bricks in my stacks currently results in a
error on the
mp_stacks_magnificPopupvariable. A little bit of digging in the console revealed that theinstanceproperty on$.magnificPopupwas always null, but the$.magnificPopupitself has theopen()andclose()functions we need.Hopefully this is a genuine fix and not just some bizarre quirk that I am seeing.