Skip to content

enhance(frontend): remove v-code-diff#17115

Open
kakkokari-gtyih wants to merge 10 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-remove-v-code-diff
Open

enhance(frontend): remove v-code-diff#17115
kakkokari-gtyih wants to merge 10 commits intomisskey-dev:developfrom
kakkokari-gtyih:enh-remove-v-code-diff

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 22, 2026

What

MkCodeで直接diffを扱えるようにしてv-code-diffを削除

image

Why

#17028

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.84%. Comparing base (d215421) to head (69890d5).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkCode.vue 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17115       +/-   ##
============================================
- Coverage    63.52%   13.84%   -49.69%     
============================================
  Files         1161      241      -920     
  Lines       115939    11664   -104275     
  Branches      7684     3949     -3735     
============================================
- Hits         73655     1615    -72040     
+ Misses       40078     7883    -32195     
+ Partials      2206     2166       -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 22, 2026 01:04
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 22, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Jan 22, 2026

MkCodeDiffみたいなコンポーネントを作ってMkCodeを隠蔽する形が奇麗かもしれない

Off topic: 設定の変更をJSのDiff形式で提示するのは親切ではなく、ちゃんとした表示を実装するまでの仮の実装だから、将来的にはより分かりやすいUIを実装したい
そうすればDiff表示実装自体を消せる

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

結局ハイライター側(MkCode.core)で直接diffを見てスタイルを適用する都合上、propsを受けて渡すだけのコンポーネントを作ることになるので無駄そう

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

結局ハイライター側(MkCode.core)で直接diffを見てスタイルを適用する都合上、propsを受けて渡すだけのコンポーネントを作ることになるので無駄そう

Related to #16122 (comment)

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Jan 22, 2026

Diffを表示する箇所は限られるからパフォーマンスは気にする必要はないわね

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

そこで対応を変える意味があるかはあまりよくわからなかったけどとりあえずそうした

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Jan 22, 2026

Diffを表示する手段はMkCode以外にも現実的に考えられるから隠蔽しておいた方が得

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants