Fix dark editor theme bleeding into light preview#167
Open
andrejkurusiov wants to merge 1 commit into
Open
Conversation
VS Code's built-in markdown.css styles elements using --vscode-* CSS variables, which resolve to dark-theme values when the editor uses a dark theme. This causes headings, code blocks, links, borders, and other elements to render with dark-theme colours even when colorTheme is forced to light. Remap --vscode-* variables within .github-markdown-body to the extension's own GitHub theme variables, and add !important overrides on affected elements to ensure full isolation. Relates to: mjbvz#48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #165
Summary
When using a dark VS Code editor theme with
colorThemeforced tolight, headings, code blocks, links, borders, and other elements render with dark-theme colours instead of the GitHub light palette.VS Code's built-in
markdown.cssstyles elements using--vscode-*CSS variables, which resolve to dark-theme values from the editor.base.cssdid not override them.Changes
--vscode-editor-foreground,--vscode-foreground,--vscode-textCodeBlock-background,--vscode-widget-border, and--vscode-editor-font-familywithin.github-markdown-bodyto the extension's own theme variables!importantoverrides on headings, links, code blocks, blockquotes, tables, andhrTest plan
workbench.colorThemeto any dark theme (e.g. One Dark Pro Darker)markdown-preview-github-styles.colorThemetolighthrcolorThemetoautoanddark, verify no regressions