Skip to content

fix(swe-bench): validate model_params before reading generation settings #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arekay-nv wants to merge 1 commit into from
Closed

fix(swe-bench): validate model_params before reading generation settings #476

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/inference_endpoint/evaluation/swe_bench_fleet_scorer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,15 @@ def score(self) -> tuple[float | None, int]:
self._model_name = model_name
self._endpoint_urls = endpoint_urls
self._endpoint_api_key = endpoint_config.get("api_key")
self._generation_params = SWEBenchScorer._generation_params(model_params)
# load_benchmark_config() yaml.safe_load()s config.yaml, so model_params
# is a plain mapping here, while _generation_params() expects the
# pydantic ModelParams. Re-validate rather than re-implement the field
# selection, so the fleet path and the single-service path agree.
from ..config.schema import ModelParams

self._generation_params = SWEBenchScorer._generation_params(
ModelParams.model_validate(model_params)
)
self._unit_root = unit_root

def fingerprint() -> str | None:
Expand Down
Loading