Exclude private submodules (e.g., _edf) from Credits page#13673
Open
Aniketsy wants to merge 8 commits intomne-tools:mainfrom
Open
Exclude private submodules (e.g., _edf) from Credits page#13673Aniketsy wants to merge 8 commits intomne-tools:mainfrom
Aniketsy wants to merge 8 commits intomne-tools:mainfrom
Conversation
Aniketsy
requested review from
agramfort,
drammock and
larsoner
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
Contributor
Author
|
@drammock gentle ping, please have a look in this, when you get chance. |
larsoner
reviewed
Apr 2, 2026
doc/changes/dev/13673.other.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Reorganized EDF submodule structure by moving private functionality into the public ``mne.io.edf`` namespace to improve module consistency and avoid exposing private modules in the Credits page, by `Aniket Singh Yadav`_. No newline at end of file | |||
Member
There was a problem hiding this comment.
We don't currently have mne.io.edf, just mne.io
larsoner
requested changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13662