Skip to content

Adding sensitivity maps for forward models in mne.report#13722

Open
1himan wants to merge 8 commits intomne-tools:mainfrom
1himan:issue-2828
Open

Adding sensitivity maps for forward models in mne.report#13722
1himan wants to merge 8 commits intomne-tools:mainfrom
1himan:issue-2828

Conversation

@1himan
Copy link
Copy Markdown
Contributor

@1himan 1himan commented Mar 5, 2026

Reference issue (if any)

Fixes #2828.

What does this implement/fix?

now the report looks something like this:

image

@tsbinns
Copy link
Copy Markdown
Contributor

tsbinns commented Mar 5, 2026

@1himan Just FYI, the :meth: formatting was recently fixed here: #13690
In the first screenshot, you are looking at the stable documentation where this has not been fixed, but if you look at the dev docs online or in your second screenshot, it is fixed (regardless of the newline change).

@1himan
Copy link
Copy Markdown
Contributor Author

1himan commented Mar 5, 2026

@1himan Just FYI, the :meth: formatting was recently fixed here: #13690 In the first screenshot, you are looking at the stable documentation where this has not been fixed, but if you look at the dev docs online or in your second screenshot, it is fixed (regardless of the newline change).

nice. I'll change accordingly.

Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget doc/changes/13722.newfeature.rst as well

Copy link
Copy Markdown
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1himan if you push commits to fix, feel free to ping us for re-review. Most folks aren't notified about commit pushes!

One last tweak -- can you modify https://mne.tools/stable/auto_tutorials/intro/70_report.html#adding-a-forward-solution to use sensitivity=True to showcase this feature (and implicitly test it by getting CircleCI to render it)?

@larsoner
Copy link
Copy Markdown
Member

larsoner commented Apr 3, 2026

Looks like the modification failed:

        ../tutorials/intro/70_report.py failed leaving traceback:
    
        Traceback (most recent call last):
          File "/home/circleci/project/tutorials/intro/70_report.py", line 335, in <module>
            report.add_forward(
          File "/home/circleci/project/mne/report/report.py", line 1589, in add_forward
            self._add_forward(
          File "/home/circleci/project/mne/report/report.py", line 3670, in _add_forward
            raise ValueError(
        ValueError: No MEG or EEG channels found in forward solution. Cannot compute sensitivity maps.

Can you fix and ping me once CIs are green?

@1himan
Copy link
Copy Markdown
Contributor Author

1himan commented Apr 4, 2026

Looks like the modification failed:

        ../tutorials/intro/70_report.py failed leaving traceback:
    
        Traceback (most recent call last):
          File "/home/circleci/project/tutorials/intro/70_report.py", line 335, in <module>
            report.add_forward(
          File "/home/circleci/project/mne/report/report.py", line 1589, in add_forward
            self._add_forward(
          File "/home/circleci/project/mne/report/report.py", line 3670, in _add_forward
            raise ValueError(
        ValueError: No MEG or EEG channels found in forward solution. Cannot compute sensitivity maps.

Can you fix and ping me once CIs are green?

sure I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add option in "mne report" to get sensitivity maps of forward models

3 participants