Conversation
|
Main change is bumping SciPy from 1.12 to 1.13, but this test is failing due to an lwork issue https://github.com/mne-tools/mne-python/actions/runs/24017356809/job/70039303111?pr=13814#step:21:5171 mne-python/mne/tests/test_chpi.py Lines 886 to 890 in 18ffc24 @larsoner Is this something that could still be due to a bug in SciPy 1.13, or is it a legit failure on our end? |
Probably a SciPy bug, the 1.13 in that check was probably a guess. Let's just bump it to 1.14 and maybe add a comment that it is also a guess so that in 6 months we know just to tweak it again 😄 @tsbinns do you have time to go through and look at |
|
(I consider this a blocker for release so would be good to do it in the next day or two!) |
|
Marking for merge-when-green, thanks @tsbinns ! |
* upstream/main: (83 commits) [pre-commit.ci] pre-commit autoupdate (mne-tools#13818) MAINT: Update dependency specifiers (mne-tools#13814) FIX: correct sensor name ordering in plot_topomap when using Info object (mne-tools#13686) ENH: Add support for plotting ICA source timecourses in Report.add_ica (mne-tools#13697) fixed some info fields in MEG interpolation across sensor types using… (mne-tools#13759) [dependabot]: Bump the actions group with 2 updates (mne-tools#13817) DOC: Fix type annotation for order parameter in Epochs.plot() (mne-tools#13639) Add pybispectra as related software (mne-tools#13812) ENH: Add initial BCI2000 .dat reader (preload-only) (mne-tools#13699) BUG: Fix bug with fwd.info["dev_head_t"] setting (mne-tools#13619) MAINT: Remove tomli, tomlsort, and ruff from `test` group (mne-tools#13809) MAINT: Make sys_info more robust (mne-tools#13810) ENH: Replace custom _whosmat_hdf5 with pymatreader.whosmat (mne-tools#13753) MAINT: Install SciPy pre (mne-tools#13807) ENH: add cmap parameter to Evoked.animate_topomap (mne-tools#13756) ENH: expose font_file in Brain.add_text (mne-tools#13778) Replacing abstractclassmethod with abstractmethod (mne-tools#13806) FIX: short-circuit n_jobs=None to n_jobs=1 without Parallel setup (mne-tools#13777) MAINT: Update code credit (mne-tools#13805) Fix top and bottom clipping in raw.plot() (mne-tools#13787) ...
Created by spec_zero GitHub action.
It is very likely that
tools/environment_old.ymlneeds to be updated.Adjustments may need to be made to shims in
mne/fixes.pyand elswhere in this or another PR.git grep TODO VERSIONis a good starting point for finding potential updates.