ENH: Add public LayeredMesh and brain.layered_meshes#13970
Open
payamsash wants to merge 12 commits into
Open
Conversation
payamsash
requested review from
drammock,
larsoner and
wmvanvliet
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
wmvanvliet
reviewed
Jun 20, 2026
| def layered_meshes(self): | ||
| """Dict of :class:`~mne.viz.LayeredMesh` objects keyed by hemisphere.""" | ||
| return self._layered_meshes | ||
|
|
Contributor
There was a problem hiding this comment.
What is the purpose here of having a property that shadows a private variable? Why not rename brain._layered_meshes -> brain.layered_meshes?
Author
There was a problem hiding this comment.
yes it's unnecessary, I'll drop/rename. tnx
…data overlays [circle linkcheck]
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
#13949
What does this implement/fix?
Adds the streaming API discussed in the issue:
_LayeredMeshchanged toLayeredMesh(public, with_LayeredMeshalias kept for compat)LayeredMesh.smooth_mat: sparse matrix applied automatically inadd_overlay/update_overlayBrain.add_data(key="data"): named overlaysBrain.layered_meshes: access the mesh dict directlyset_data_smoothing()now syncssmooth_matonto the meshLayeredMeshexported frommne.vizAdditional information