fix(filesystem): support cross-device moves - #4720
Open
Excelius-Wang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fall back to a staged copy-and-remove operation when
move_fileencounters anEXDEVcross-device rename error.Server Details
move_filetoolMotivation and Context
fs.renamecannot move files or directories across filesystem boundaries. This commonly occurs between container volumes, network mounts, and local disks.The fallback copies the source to a randomized temporary path beside the destination, renames the completed copy into place, and removes the source only after finalization. Failed copies are cleaned up without exposing a partial destination.
Relative symbolic links, timestamps, permissions, and the existing no-overwrite behavior are preserved.
How Has This Been Tested?
npm test— 174 passednpm run build/tmpand/dev/shmEXDEVerrors do not trigger the fallbackBreaking Changes
None. Same-filesystem moves continue to use the existing
renamepath.Types of changes
Checklist