Skip to content

fix: open path util freezing app #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Prospector merged 3 commits into from
Jan 15, 2026
Merged

fix: open path util freezing app #5111

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
18b0fec
fix open path util crashing app
tdgao Jan 13, 2026
eeba8d1
use spawn blocking instead
tdgao Jan 13, 2026
9c8c950
fmt
tdgao Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions apps/app/src/api/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,19 +93,24 @@ pub fn highlight_in_folder<R: Runtime>(
}

#[tauri::command]
pub fn open_path<R: Runtime>(app: tauri::AppHandle<R>, path: PathBuf) {
if let Err(e) = app.opener().open_path(path.to_string_lossy(), None::<&str>)
{
tracing::error!("Failed to open path: {}", e);
}
pub async fn open_path<R: Runtime>(app: tauri::AppHandle<R>, path: PathBuf) {
tauri::async_runtime::spawn_blocking(move || {
if let Err(e) =
app.opener().open_path(path.to_string_lossy(), None::<&str>)
{
tracing::error!("Failed to open path: {}", e);
}
})
.await
.ok();
}

#[tauri::command]
pub fn show_launcher_logs_folder<R: Runtime>(app: tauri::AppHandle<R>) {
pub async fn show_launcher_logs_folder<R: Runtime>(app: tauri::AppHandle<R>) {
let path = DirectoryInfo::launcher_logs_dir().unwrap_or_default();
// failure to get folder just opens filesystem
// (ie: if in debug mode only and launcher_logs never created)
open_path(app, path);
open_path(app, path).await;
}

// Get opening command
Expand Down