Fix TV render sizing for non-TV panels#16809
Closed
smg6511 wants to merge 3 commits intomodxcms:3.xfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.x #16809 +/- ##
============================================
- Coverage 21.54% 21.45% -0.09%
- Complexity 10734 10769 +35
============================================
Files 565 566 +1
Lines 32616 32948 +332
============================================
+ Hits 7026 7069 +43
- Misses 25590 25879 +289 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@theboxer - Greetings - I see you've reviewed a couple of my UI-related PRs today. Thanks for that! It'd be great if you could check this one out as well ;-) |
opengeek
requested changes
Jan 29, 2026
Implement more reliable and flexible sizing specs via css
78e2ec9 to
924dde5
Compare
Collaborator
Author
|
@opengeek Ok, I think I got it sorted. It was odd though that the conflict was coming from one of the non-English lexicon files 🤷 Ehhh, strike that: What the h#ll is going on with this one !? I don't get why the rebase is behaving this way. Will try again... |
smg6511
added a commit
to smg6511/revolution
that referenced
this pull request
Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
Collaborator
Author
smg6511
added a commit
to smg6511/revolution
that referenced
this pull request
Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
opengeek
pushed a commit
to smg6511/revolution
that referenced
this pull request
Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What does it do?
Implement more reliable and flexible sizing specs via updated css, removing explicit widths from Ext configs. The changes allow every built-in TV type to display correctly, no matter where they are placed.
Why is it needed?
Many TV types do not render well when moved to the various Resource regions, overflowing the region boundaries. In some cases the inner input (holding the current value) also obscured the right border because of incorrect sizing.
How to test
grunt buildwhile in the_build/templates/defaultfolderRelated issue(s)/PR(s)
Resolves #12839 and #13977
Special Note
More work could be done to improve the styling overall (e.g., maybe more space vertically between fields, fine-tuning spacing and sizing of the descriptions/labels, etc.) and I did not focus much on the mobile view as there are problems to fix there beyond TV rendering which are out of scope of this fix.