Skip to content

Fix TV render sizing for non-TV panels#16809

Closed
smg6511 wants to merge 3 commits intomodxcms:3.xfrom
smg6511:3.x-issue-12839
Closed

Fix TV render sizing for non-TV panels#16809
smg6511 wants to merge 3 commits intomodxcms:3.xfrom
smg6511:3.x-issue-12839

Conversation

@smg6511
Copy link
Copy Markdown
Collaborator

@smg6511 smg6511 commented Jan 6, 2026

What does it do?

Implement more reliable and flexible sizing specs via updated css, removing explicit widths from Ext configs. The changes allow every built-in TV type to display correctly, no matter where they are placed.

Why is it needed?

Many TV types do not render well when moved to the various Resource regions, overflowing the region boundaries. In some cases the inner input (holding the current value) also obscured the right border because of incorrect sizing.

How to test

  1. Run grunt build while in the _build/templates/default folder
  2. Create each TV type (two of each if wanting to test the render to the TV panel and to Resource regions at the same time)
  3. Setup Form Customization to move each TV type to one of the Resource regions.
  4. Verify width and general sizing is consistent with other built-in fields as well as among moved TVs

Related issue(s)/PR(s)

Resolves #12839 and #13977

Special Note

More work could be done to improve the styling overall (e.g., maybe more space vertically between fields, fine-tuning spacing and sizing of the descriptions/labels, etc.) and I did not focus much on the mobile view as there are problems to fix there beyond TV rendering which are out of scope of this fix.

@smg6511 smg6511 added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed requires build Grunt build is required for integration labels Jan 6, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.45%. Comparing base (304208d) to head (39e9c33).
⚠️ Report is 3 commits behind head on 3.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16809      +/-   ##
============================================
- Coverage     21.54%   21.45%   -0.09%     
- Complexity    10734    10769      +35     
============================================
  Files           565      566       +1     
  Lines         32616    32948     +332     
============================================
+ Hits           7026     7069      +43     
- Misses        25590    25879     +289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smg6511
Copy link
Copy Markdown
Collaborator Author

smg6511 commented Jan 26, 2026

@theboxer - Greetings - I see you've reviewed a couple of my UI-related PRs today. Thanks for that! It'd be great if you could check this one out as well ;-)

Copy link
Copy Markdown
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

Before:

Image

After:

Image

Copy link
Copy Markdown
Member

@opengeek opengeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smg6511 — unfortunately, I cannot merge this PR as is. The two merge commits you added cause conflicts when I perform the rebase I have to do before the grunt build. Can you remove those merge commits and rebase 7b09ed7 on top of 3.x? You'll have to force push.

Implement more reliable and flexible sizing specs via css
This reverts commit 37b3bf8, reversing
changes made to 39e9c33.
This reverts commit 39e9c33, reversing
changes made to 7b09ed7.
@smg6511
Copy link
Copy Markdown
Collaborator Author

smg6511 commented Jan 30, 2026

@opengeek Ok, I think I got it sorted. It was odd though that the conflict was coming from one of the non-English lexicon files 🤷

Ehhh, strike that: What the h#ll is going on with this one !? I don't get why the rebase is behaving this way. Will try again...

smg6511 added a commit to smg6511/revolution that referenced this pull request Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
@smg6511
Copy link
Copy Markdown
Collaborator Author

smg6511 commented Jan 30, 2026

@theboxer - Hey, when you get a chance can you jump over to #16819 and give it a quick peak and approval (as you did here)? My rebasing of this PR got all botched up and it was easier to just re-sumbit these changes on a clean branch. No new changes were made. Thanks!

@smg6511 smg6511 marked this pull request as draft January 30, 2026 15:25
smg6511 added a commit to smg6511/revolution that referenced this pull request Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
opengeek pushed a commit to smg6511/revolution that referenced this pull request Jan 30, 2026
Clean commit on new branch to fix issues rebasing the original PR in prep for merge
@opengeek opengeek closed this Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires build Grunt build is required for integration type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combo Boxes cut off with Manager Form Customization

3 participants