Perf: Optimize string concatenation across multiple files#288
Merged
mondeja merged 5 commits intomondeja:masterfrom Jan 25, 2026
Merged
Perf: Optimize string concatenation across multiple files#288mondeja merged 5 commits intomondeja:masterfrom
mondeja merged 5 commits intomondeja:masterfrom
Conversation
mondeja
approved these changes
Jan 25, 2026
Owner
mondeja
left a comment
There was a problem hiding this comment.
Tested locally and it's ~4% faster. Thank you!
Contributor
Author
|
Glad to hear that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes string construction in
directive.py,process.py, andevent.pyby replacing repeated+=concatenation inside loops with list accumulation and''.join().The Issue: In Python, strings are immutable. Using
+=to append to a string inside a loop forces the interpreter to create a new string object and copy the old content for every iteration. This results in quadratic time complexityO(n^2), which can significantly degrade performance when processing large inputs.The Solution: I refactored the string construction logic to collect substrings in a list and use
''.join()at the end. This approach ensures linear time complexityO(n)because the total size of the final string is calculated once, and memory is allocated efficiently.This is in line with standard python performance recommendation: https://peps.python.org/pep-0008/#programming-recommendations