Fix reactive streams MongoClient.getTimeout always returning null#2009
Open
stIncMale wants to merge 1 commit into
Open
Fix reactive streams MongoClient.getTimeout always returning null#2009stIncMale wants to merge 1 commit into
MongoClient.getTimeout always returning null#2009stIncMale wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the Reactive Streams driver’s MongoClient.getTimeout(TimeUnit) implementation so it reports the configured operation timeout (instead of always returning null), and aligns nullability annotations with the public API contract.
Changes:
- Reactive Streams:
MongoClientImpl.getTimeoutnow delegates to the underlying cluster implementation. - Reactive Streams + Sync: add
@NullabletogetTimeoutoverrides to match theMongoClusterAPI contract.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| driver-sync/src/main/com/mongodb/client/internal/MongoClientImpl.java | Adds @Nullable to getTimeout override to match MongoCluster#getTimeout contract. |
| driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/MongoClusterImpl.java | Adds @Nullable to getTimeout override (note: conversion logic in this method needs correction per review comment). |
| driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/MongoClientImpl.java | Fixes Reactive Streams MongoClient.getTimeout to delegate instead of always returning null; marks return as @Nullable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stIncMale
requested review from
rozza and
vbabanin
and removed request for
vbabanin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI was used only to review.
JAVA-6246