PYTHON-5781 Increase code coverage for network_layer.py#2774
Open
aclark4life wants to merge 6 commits intomongodb:masterfrom
Open
PYTHON-5781 Increase code coverage for network_layer.py#2774aclark4life wants to merge 6 commits intomongodb:masterfrom
aclark4life wants to merge 6 commits intomongodb:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated unit test suite to increase coverage of pymongo/network_layer.py, focusing on logic that can be validated without live sockets or a running MongoDB server.
Changes:
- Introduces
test/test_network_layer.pywith unit tests forPyMongoProtocolstate transitions and message parsing helpers. - Adds delegation/behavior tests for
NetworkingInterfaceBase,NetworkingInterface, andAsyncNetworkingInterface. - Adds tests for small helper functions (
sendall,_async_socket_receive) using mocks.
| def test_returns_op_code_and_compressor_id(self): | ||
| async def _test(): | ||
| proto = await _make_protocol() | ||
| # op_code=2013, unknown int=0, compressor_id=1 (snappy) |
There was a problem hiding this comment.
The comment describing the OP_COMPRESSED header layout is inaccurate: the second int in <iiB is the uncompressed message size (per the wire protocol), not an “unknown int”. Updating the comment will avoid confusion for future readers maintaining these tests.
Suggested change
| # op_code=2013, unknown int=0, compressor_id=1 (snappy) | |
| # op_code=2013, uncompressed message size=0, compressor_id=1 (snappy) |
aclark4life
changed the title
6 tasks
Add test/test_network_layer.py with 56 unit tests covering: - PyMongoProtocol: process_header (including ProtocolError paths), process_compression_header, get_buffer (all state branches), buffer_updated (state machine), close/connection_lost lifecycle - NetworkingInterfaceBase: abstract method NotImplementedError raises - NetworkingInterface: socket delegation methods - AsyncNetworkingInterface: transport/protocol delegation - sendall: trivial delegation - _async_socket_receive: success and connection-closed paths
- Fix mypy type error in test_network_layer.py - Use 'from test import unittest', remove self-evident docstrings from helpers - Fix inaccurate comment: second field in compression header is uncompressed_size
- Add test/asynchronous/test_network_layer.py as the async source of truth with AsyncUnitTest and _IS_SYNC = False - Regenerate test/test_network_layer.py via synchro from the async source - Register test_network_layer.py in synchro converted_tests (alpha order) - Add "AsyncMock": "MagicMock" replacement after AsyncMockPool to avoid substring collision in translate_docstrings
Applying feedback from PYTHON-5784 to all open codecov PRs
aclark4life
force-pushed
the
PYTHON-5781
branch
3 times, most recently
from
15ebabb to
1a2384a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHON-5781
Changes in this PR
Adds
test/test_network_layer.pywith unit tests forpymongo/network_layer.py. Tests coverPyMongoProtocolstate machine (process_headerincluding allProtocolErrorpaths,process_compression_header,get_bufferall state branches,buffer_updated,close,connection_lost),NetworkingInterfaceBaseabstract methods,NetworkingInterfacesocket delegation,AsyncNetworkingInterfacetransport/protocol delegation,sendall, and_async_socket_receive.Test Plan
Added unit tests using mock transports and
asyncio.run()to exercise the asyncio-dependent protocol code. No live socket or MongoDB server required.Checklist
Checklist for Author
Checklist for Reviewer