Running conditionally precommit_and_push job #656
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run
precommit_and_pushtasks only when it's actually necessary.Because of the evergreen limitation that github tokens are not available, whenever we run a stacked PR that is not based on master, we've been getting a red
precommit_and_pushtask.In any case running precommit_and_push task is needed to be green on stacked PR it is necessary to clone evergreen project for the base branch.
Proof of Work
Bump PR that should run precommit_and_push and the conditional task is adding it (it's failed because the PR is not based on master, it's expected): link
Other PR that doesn't need it is skipping it: link