Add github action to test on current ruby versions#7
Open
telyn wants to merge 1 commit intomostlyobvious:masterfrom
Open
Add github action to test on current ruby versions#7telyn wants to merge 1 commit intomostlyobvious:masterfrom
telyn wants to merge 1 commit intomostlyobvious:masterfrom
Conversation
For some reason ruby 3.3 and jruby were failing to install the gems, so I haven't included them in the github-actions workflow. When testing locally they worked fine though - don't know the cause. The "set" library seems to need explicitly requiring these days, too, so I've done that in the test file - though really it ought be done inside mutant-minitest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heya - thanks for making this gem :-) I was about to implement my own exponential backoff mechanism at work and then discovered it. Wanted to make sure it'd fit us for the long term so I set up a fork to test against newer rubies using github-actions. Figured I'd contribute it back just so anyone coming to your repo has good confidence that it works on newer rubies.
For some reason ruby 3.3 and jruby were failing to install the gems in github-actions, so I haven't included them in the workflow. When testing locally they worked fine though - don't know the cause.
The "set" library seems to need explicitly requiring these days, too, so I've done that in the test file - though I know really it ought be done inside mutant-minitest.