Always include commit summaries in bug descriptions; split long ones across multiple comments#416
Open
padenot wants to merge 1 commit into
Open
Always include commit summaries in bug descriptions; split long ones across multiple comments#416padenot wants to merge 1 commit into
padenot wants to merge 1 commit into
Conversation
…across multiple comments The commit summary in https://bugzilla.mozilla.org/show_bug.cgi?id=2033562#c0 was gated behind verbosity >= 2, so it was dropped whenever the description fell back to verbosity 1 due to length, making it impossible to audit a large series of commits without following each individual link. Replace the verbosity-reduction fallback with a greedy splitter that always emits full commit details and splits across multiple Bugzilla comments when the 65535-character limit is reached. For GitHub and GitLab repos, the first comment gets a compare URL (old...new) so reviewers can see the whole range at a glance. googlesource hosts are excluded as they use a different URL structure. We could add others, e.g. videolan and ffmpeg are now using forgejo and gitlab, but I don't have an idea besides hardcoding. Both the commitalert and vendoring flows now post overflow chunks as follow-up comments rather than silently dropping them.
Contributor
Author
|
@tomrittervg if you want to have a look? |
Collaborator
|
So we can't take this as-is or we're going to be doing a lot of work for the 55,000 commits in https://bugzilla.mozilla.org/show_bug.cgi?id=2033277 Presuming you'd still like this feature, I think what I will do is add some convenience flag in a moz.yaml that would let you enable this behavior |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit summary inhttps://bugzilla.mozilla.org/show_bug.cgi?id=2033562#c0 was gated behind verbosity >= 2, so it was dropped whenever the description fell back to verbosity 1 due to length, making it impossible to audit a large series of commits without following each individual link.
Replace the verbosity-reduction fallback with a greedy splitter that always emits full commit details and splits across multiple Bugzilla comments when the 65535-character limit is reached. For GitHub and GitLab repos, the first comment gets a compare URL (old...new) so reviewers can see the whole range at a glance. googlesource hosts are excluded as they use a different URL structure. We could add others, e.g. videolan and ffmpeg are now using forgejo and gitlab, but I don't have an idea besides hardcoding.
Both the commitalert and vendoring flows now post overflow chunks as follow-up comments rather than silently dropping them.