Parse moz.yaml task 'options' into Task.options dict#417
Merged
Conversation
The moz.yaml vendoring/commit-alert task schema now accepts an 'options'
array of strings. Capture it in validate_task (defaulting to an empty
list) and expose it on Task as an 'options' dict where every value listed
in the moz.yaml maps to True (an unspecified/empty list yields {}).
Also cover this in the libraryprovider test: the cubeb-path moz.yaml
fixture gains an 'options' array and the matching expected Library is
updated, so testLibraryFindAndImport exercises options flowing through
get_libraries() into the Task.options dict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The moz.yaml vendoring/commit-alert task schema now accepts an 'options' array of strings. Capture it in validate_task (defaulting to an empty list) and expose it on Task as an 'options' dict where every value listed in the moz.yaml maps to True (an unspecified/empty list yields {}).
Also cover this in the libraryprovider test: the cubeb-path moz.yaml fixture gains an 'options' array and the matching expected Library is updated, so testLibraryFindAndImport exercises options flowing through get_libraries() into the Task.options dict.
Goes along with https://bugzilla.mozilla.org/show_bug.cgi?id=2050952