Skip to content

chore(project): pin remaining actions and scope update-workflow app tokens#16335

Merged
jaredlockhart merged 2 commits into
mainfrom
16333
Jul 16, 2026
Merged

chore(project): pin remaining actions and scope update-workflow app tokens#16335
jaredlockhart merged 2 commits into
mainfrom
16333

Conversation

@jaredlockhart

@jaredlockhart jaredlockhart commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Because

  • zizmor enforces a blanket policy requiring all external actions to be pinned to a commit SHA; the first-party actions and docker/setup-buildx-action were not covered by the initial third-party pinning.
  • zizmor also flags create-github-app-token steps that inherit blanket installation permissions.

This commit

  • Pins all remaining external actions (actions/*, mozilla-it/deploy-actions, docker/setup-buildx-action) to commit SHAs at their current versions, with the version recorded in a trailing comment.
  • Scopes the app tokens in update-configs.yml and update-firefox.yml to contents:write + pull-requests:write, the only permissions those workflows use.

Fixes #16333

Because

* zizmor enforces a blanket policy requiring all external actions to be pinned to a commit SHA; the first-party actions and docker/setup-buildx-action were not covered by the initial third-party pinning.

This commit

* Pins all remaining external actions (actions/*, mozilla-it/deploy-actions, docker/setup-buildx-action) to commit SHAs at their current versions, with the version recorded in a trailing comment.

Fixes #16333
Comment thread .github/workflows/update-configs.yml Fixed
Comment thread .github/workflows/update-configs.yml Fixed
Comment thread .github/workflows/update-firefox.yml Fixed
Because

* zizmor flags create-github-app-token steps that inherit blanket installation permissions.

This commit

* Scopes the app tokens in update-configs.yml and update-firefox.yml to contents:write + pull-requests:write, the only permissions those workflows use.

Fixes #16333
@jaredlockhart jaredlockhart changed the title chore(project): pin remaining github actions to commit shas chore(project): pin remaining actions and scope update-workflow app tokens Jul 15, 2026
@jaredlockhart jaredlockhart marked this pull request as ready for review July 15, 2026 21:29
@jaredlockhart jaredlockhart enabled auto-merge July 15, 2026 21:29
@jaredlockhart jaredlockhart added this pull request to the merge queue Jul 16, 2026
Merged via the queue into main with commit 6cbb4f6 Jul 16, 2026
30 checks passed
@jaredlockhart jaredlockhart deleted the 16333 branch July 16, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin remaining GitHub Actions to commit SHAs (first-party + docker/setup-buildx)

3 participants