Skip to content

bug(settings): Make sure that PostVerify/SetPassword is aligned with Signup/Setpassword#20828

Merged
dschom merged 1 commit into
mainfrom
FXA-14047.2
Jul 14, 2026
Merged

bug(settings): Make sure that PostVerify/SetPassword is aligned with Signup/Setpassword#20828
dschom merged 1 commit into
mainfrom
FXA-14047.2

Conversation

@dschom

@dschom dschom commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Because:

  • We want users to have a consistent experience when 'setting' paswords

This Commit:

  • Ensures the legal links are correct when going through a VPN flow.
  • Ensures the cms info is infact rendered properly
  • Adds CMS: prefix to mocks to disambiguate cms content from default content
  • Fixes the position of the displayed email to come after the cms description.

Issue that this pull request solves

Closes: FXA-14124, FXA-14125

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).
  • I have manually reviewed all AI generated code.

How to review (Optional)

  • Key files/areas to focus on:
  • Suggested review order:
  • Risky or complex parts:

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

The quickest way to validate is by looking that the story books. Note the the strapi config will also need updating to fully close out the ticket.

@dschom dschom requested a review from a team as a code owner July 7, 2026 22:11
@dschom dschom changed the title Fxa 14047.2 bug(settings): Make sure that PostVerify/SetPassword is aligned with Signup/Setpassword Jul 7, 2026

@vbudhram vbudhram left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschom Did we confirm with product about the ToS? I personally think adding that is fine and figuring a better process to keep string consistent.

…Signup/Setpassword

Because:
- We want users to have a consistent experience when 'setting' paswords

This Commit:
- Ensures the legal links are correct when going through a VPN flow.
- Ensures the cms info is infact rendered properly
- Adds CMS: prefix to mocks to disambiguate cms content from default content
- Fixes the position of the displayed email to come after the cms description.
@dschom

dschom commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

@dschom Did we confirm with product about the ToS? I personally think adding that is fine and figuring a better process to keep string consistent.

I brought it up with two product people. I think the general sentiment was that its technically not needed on this page, but showing it doesn't hurt. I argued that the consistency between pages is a good thing and helps with overall feel and helps remove any ambiguity from QA's perspective. After all they viewed this a bug.

@dschom dschom merged commit f073f19 into main Jul 14, 2026
21 checks passed
@dschom dschom deleted the FXA-14047.2 branch July 14, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants