bug(settings): Make sure that PostVerify/SetPassword is aligned with Signup/Setpassword#20828
Merged
Conversation
…Signup/Setpassword Because: - We want users to have a consistent experience when 'setting' paswords This Commit: - Ensures the legal links are correct when going through a VPN flow. - Ensures the cms info is infact rendered properly - Adds CMS: prefix to mocks to disambiguate cms content from default content - Fixes the position of the displayed email to come after the cms description.
Contributor
Author
I brought it up with two product people. I think the general sentiment was that its technically not needed on this page, but showing it doesn't hurt. I argued that the consistency between pages is a good thing and helps with overall feel and helps remove any ambiguity from QA's perspective. After all they viewed this a bug. |
vbudhram
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This Commit:
Issue that this pull request solves
Closes: FXA-14124, FXA-14125
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
The quickest way to validate is by looking that the story books. Note the the strapi config will also need updating to fully close out the ticket.