Bug 2026342 : Replace truncated subtest names with full name #1023
Merged
kala-moz merged 2 commits intomozilla:mainfrom Apr 7, 2026
Merged
Bug 2026342 : Replace truncated subtest names with full name #1023kala-moz merged 2 commits intomozilla:mainfrom
kala-moz merged 2 commits intomozilla:mainfrom
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kala-moz
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1023 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 110 111 +1
Lines 3143 3148 +5
Branches 708 712 +4
=======================================
+ Hits 3023 3028 +5
Misses 118 118
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Reduce significance col and switched places with cles; updated test to reflect col changes.
Merged
kala-moz
added a commit
that referenced
this pull request
Apr 7, 2026
Changelog: [kala] - Bug: 2020622 Updated column title from Total Runs to Total Trials #1012 - Bug 2024075 Test Version Refactor: Moved subtest columns to test version strategy and test version files #1017 - Bug 2022720 Test Version Refactor: Refactor how the expanded row's components are rendered #1016 - Bug 2027906 Test Version Refactor: remove hard coded array in Test Version Dropdown and replace with call to label options in registry #1020 - Bug 2026342 : Replace truncated subtest names with full name #1023 [moijes12] - Bug-2020964 Update Contributing section in README #1009 - Bug-2022758 Remove redundant Dark fonts #1011 [padenot] - Median diff gated #1019 [mgaudet] - Bug 2024042 - Add median diff column #1015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Bug 2026342.
In order to show the full name of the subtests for Mann-Whitney-U, the
Significancecolumn (now calledSig) was reduced in size,Significanttext replaced with up arrow icon,Not Significantreplaced with -, and the col switched places with the CLES column for better reading. This change required changing the size of the other columns as shown insrc/common/testVersions/mannWhitney.tsx. Also to make more space, reducedCliff's DeltatoCD.Furthermore, I noticed the header width didn't match the width of the cells, so an extra util was added to make sure the min-content of the cells didn't expand a track beyond its fr allocation. This creates a cleaner more aligned table.
Before: Main Link
After: Deploy Link
Lastly, the tests were updated to reflect the name changes.