Skip to content

Add the voting logic for regression detection.#9293

Merged
gmierz merged 1 commit intomozilla:masterfrom
MohamedBilelBesbes:VotingSystem
Mar 19, 2026
Merged

Add the voting logic for regression detection.#9293
gmierz merged 1 commit intomozilla:masterfrom
MohamedBilelBesbes:VotingSystem

Conversation

@MohamedBilelBesbes
Copy link
Copy Markdown
Contributor

This PR contains the following changes:

  • It introduces consensus voting: alerts only fire when at least cons_th methods agree within a margin index window
  • It adds two voting strategies: equal (all methods weighted equally) and priority (Student detections take precedence, equal voting as fallback)
  • It has a deduplication guard that prevents the redundant alerts for adjacent revisions resolving to the same regression based on the margin value
  • Alert output is now extended with per-method confidences dict and a detection_method naming field encoding the full voting configuration
  • It has new unit tests associated with the voting logic
  • Older obsolete unit tests are removed
  • replicates usage logic is fully propagated in the prototype code

Copy link
Copy Markdown
Collaborator

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start @MohamedBilelBesbes! Comments below.

@MohamedBilelBesbes MohamedBilelBesbes force-pushed the VotingSystem branch 2 times, most recently from ff053b1 to 45d8434 Compare March 18, 2026 17:45
Copy link
Copy Markdown
Collaborator

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to fix up the migrations, then I think this will be good to land

@MohamedBilelBesbes MohamedBilelBesbes force-pushed the VotingSystem branch 2 times, most recently from 7c0cf92 to bc8c06b Compare March 18, 2026 20:32
@MohamedBilelBesbes
Copy link
Copy Markdown
Contributor Author

Just need to fix up the migrations, then I think this will be good to land

@gmierz perfect, I squashed the migrations, I think we're good to go.

Copy link
Copy Markdown
Collaborator

@gmierz gmierz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ great work here @MohamedBilelBesbes!

@gmierz gmierz changed the title Adding the voting logic Add the voting logic for regression detection. Mar 19, 2026
@gmierz gmierz merged commit 5ba5489 into mozilla:master Mar 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants