Add the voting logic for regression detection.#9293
Merged
gmierz merged 1 commit intomozilla:masterfrom Mar 19, 2026
Merged
Conversation
3fad5d1 to
6d7ded9
Compare
gmierz
requested changes
Mar 17, 2026
Collaborator
gmierz
left a comment
There was a problem hiding this comment.
Great start @MohamedBilelBesbes! Comments below.
05fb8c6 to
a0455af
Compare
gmierz
requested changes
Mar 18, 2026
treeherder/perf/migrations/0064_performancealerttesting_confidences.py
Outdated
Show resolved
Hide resolved
gmierz
reviewed
Mar 18, 2026
ff053b1 to
45d8434
Compare
gmierz
requested changes
Mar 18, 2026
Collaborator
gmierz
left a comment
There was a problem hiding this comment.
Just need to fix up the migrations, then I think this will be good to land
7c0cf92 to
bc8c06b
Compare
bc8c06b to
611b6c7
Compare
Contributor
Author
@gmierz perfect, I squashed the migrations, I think we're good to go. |
gmierz
approved these changes
Mar 19, 2026
Collaborator
gmierz
left a comment
There was a problem hiding this comment.
r+ great work here @MohamedBilelBesbes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
cons_thmethods agree within amarginindex windowequal(all methods weighted equally) andpriority(Student detections take precedence, equal voting as fallback)marginvaluedetection_methodnaming field encoding the full voting configuration