Open
Conversation
Rob--W
requested changes
Jan 30, 2025
Member
Rob--W
left a comment
There was a problem hiding this comment.
This is a hack to work around ncc. We're not in favor of such a hack.
The purpose of the code here is to evaluate a config file as JS code and use its result. The use of nonce shows that import() is not exactly the perfect API here, because of its module caching behavior.
We are willing to consider non-hacky alternatives, such as logic that uses the vm module to execute code (https://nodejs.org/api/vm.html).
Contributor
Author
|
I think |
Member
|
readFile + eval (maybe with source map comment to attribute the file correctly if there is an error in it)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is a workaround so web-ext compiles with vercel's ncc. It doesn't like dynamic imports, but will happily ignore them if indirect. Any chance you'd accept this patch?
See vercel/ncc#935 for details.