Skip to content

test: use z.lazy for self-referencing collections #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kettanaito wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: use z.lazy for self-referencing collections #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/relations/many-to-many.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@ import z from 'zod'
const userSchema = z.object({
id: z.number(),
get posts() {
return z.array(postSchema)
return z.lazy(() => z.array(postSchema))
},
})

const postSchema = z.object({
title: z.string(),
get authors() {
return z.array(userSchema).optional()
return z.lazy(() => z.array(userSchema))
},
})

Expand All @@ -26,8 +26,8 @@ it('supports a many-to-many relation', async () => {
authors: many(users),
}))

const firstPost = await posts.create({ title: 'First' })
const secondPost = await posts.create({ title: 'Second' })
const firstPost = await posts.create({ title: 'First', authors: [] })
const secondPost = await posts.create({ title: 'Second', authors: [] })

const firstUser = await users.create({
id: 1,
Expand Down Expand Up @@ -59,8 +59,8 @@ it('respects updates of foreign records', async () => {
authors: many(users),
}))

const firstPost = await posts.create({ title: 'First' })
const secondPost = await posts.create({ title: 'Second' })
const firstPost = await posts.create({ title: 'First', authors: [] })
const secondPost = await posts.create({ title: 'Second', authors: [] })

const firstUser = await users.create({
id: 1,
Expand Down
2 changes: 1 addition & 1 deletion tests/relations/many-to-one.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const userSchema = z.object({
const postSchema = z.object({
title: z.string(),
get author() {
return userSchema.optional()
return z.lazy(() => userSchema)
},
})

Expand Down
59 changes: 34 additions & 25 deletions tests/relations/one-to-many.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,18 @@ import z from 'zod'
const userSchema = z.object({
id: z.number(),
get posts() {
return z.array(postSchema)
return z.lazy(() => z.array(postSchema))
},
})

const postSchema = z.object({
title: z.string(),
get author() {
return userSchema.optional()
return z.lazy(() => userSchema)
},
})

it('supports a one-to-many relation', async () => {
it.only('supports a one-to-many relation', async () => {
const users = new Collection({ schema: userSchema })
const posts = new Collection({ schema: postSchema })

Expand All @@ -25,11 +25,17 @@ it('supports a one-to-many relation', async () => {

const firstUser = await users.create({
id: 1,
posts: [await posts.create({ title: 'First' })],
posts: [],
})
const secondUser = await users.create({
id: 2,
posts: [await posts.create({ title: 'Second' })],
await posts.create({
title: 'First',
author: firstUser,
})

const secondUser = await users.create({ id: 2, posts: [] })
await posts.create({
title: 'Second',
author: secondUser,
})

expect.soft(firstUser.posts[0]).toEqual({ title: 'First' })
Expand Down Expand Up @@ -61,10 +67,13 @@ it('supports a two-way one-to-many relation', async () => {
}))

{
const post = await posts.create({ title: 'First' })
const user = await users.create({
id: 1,
posts: [post],
posts: [],
})
const post = await posts.create({
title: 'First',
author: user,
})

expect(post.author).toEqual(user)
Expand Down Expand Up @@ -159,8 +168,9 @@ it('updates an inverse relation when the referenced record is created', async ()

const user = await users.create({
id: 1,
posts: [await posts.create({ title: 'First' })],
posts: [],
})
await posts.create({ title: 'First', author: user })
await posts.create({ title: 'Second', author: user })

expect(users.findFirst((q) => q.where({ id: 1 }))).toEqual({
Expand All @@ -185,8 +195,9 @@ it('updates a one-to-many relation when the referenced record is updated', async

const user = await users.create({
id: 1,
posts: [await posts.create({ title: 'First' })],
posts: [],
})
await posts.create({ title: 'First', author: user })

await posts.update((q) => q.where({ title: 'First' }), {
data(post) {
Expand All @@ -211,10 +222,8 @@ it('updates a one-to-many relation when the referenced record is dissociated', a
author: one(users),
}))

await users.create({
id: 1,
posts: [await posts.create({ title: 'First' })],
})
const user = await users.create({ id: 1, posts: [] })
await posts.create({ title: 'First', author: user })

// Set a new author for the post.
const updatedPost = await posts.update((q) => q.where({ title: 'First' }), {
Expand Down Expand Up @@ -280,11 +289,11 @@ it('updates the relation when the owner record is deleted', async () => {

// Deleting the post, user updates.
{
const post = await posts.create({ title: 'First' })
const user = await users.create({
id: 1,
posts: [post],
posts: [],
})
const post = await posts.create({ title: 'First', author: user })

posts.delete((q) => q.where({ title: 'First' }))

Expand All @@ -300,11 +309,11 @@ it('updates the relation when the owner record is deleted', async () => {

// Deleting the user, post updates.
{
const post = await posts.create({ title: 'First' })
const user = await users.create({
id: 1,
posts: [post],
posts: [],
})
const post = await posts.create({ title: 'First', author: user })

users.delete(user)

Expand All @@ -327,11 +336,11 @@ it('cascades foreign record deletion when the owner record is deleted', async ()
author: one(users, { onDelete: 'cascade' }),
}))

const post = await posts.create({ title: 'First' })
const user = await users.create({
id: 1,
posts: [post],
posts: [],
})
const post = await posts.create({ title: 'First', author: user })

users.delete(user)

Expand All @@ -350,8 +359,8 @@ it('supports unique one-to-many relations', async () => {
author: one(users),
}))

const post = await posts.create({ title: 'First' })
const user = await users.create({ id: 1, posts: [post] })
const user = await users.create({ id: 1, posts: [] })
const post = await posts.create({ title: 'First', author: user })

expect.soft(user).toEqual({
id: 1,
Expand Down Expand Up @@ -399,8 +408,8 @@ it('errors when creating a unique relation with already associated foreign recor
author: one(users),
}))

const post = await posts.create({ title: 'First' })
await users.create({ id: 1, posts: [post] })
const user = await users.create({ id: 1, posts: [] })
const post = await posts.create({ title: 'First', author: user })

await expect(users.create({ id: 2, posts: [post] })).rejects.toThrow(
'Failed to create a unique relation at "posts": foreign records already associated with another owner',
Expand Down
Loading