fix: many relation updates via memoized arrays and guarded hooks#350
Open
unadlib wants to merge 1 commit intomswjs:mainfrom
Open
fix: many relation updates via memoized arrays and guarded hooks#350unadlib wants to merge 1 commit intomswjs:mainfrom
unadlib wants to merge 1 commit intomswjs:mainfrom
Conversation
kategengler
added a commit
to kategengler/msw-data
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #346
Fix many() relation updates so array assignments and element-level mutations keep foreignKeys and inverse links in sync, guarding the “through relation” early hook from array indices.
Solution
This fix uses memoization: the many() relation now maintains a stable resolved array (cached and mutated in place) so Mutative can draft it and emit patches on push/splice. We didn’t materialize getters into plain arrays before drafting.