Skip to content

🧹 [refactor] extract duplicated filter matching logic#94

Merged
cmuench merged 1 commit intomainfrom
refactor-filter-logic-13465693477160819443
Apr 9, 2026
Merged

🧹 [refactor] extract duplicated filter matching logic#94
cmuench merged 1 commit intomainfrom
refactor-filter-logic-13465693477160819443

Conversation

@cmuench
Copy link
Copy Markdown
Contributor

@cmuench cmuench commented Apr 5, 2026

🎯 What: Extracted duplicated regex-based filter parsing logic from buildSearchCriteria and applyLocalSearchCriteria into a new shared helper function parseFilterOption.

💡 Why: This improves maintainability and readability by eliminating code duplication and centralizing filter parsing rules (regex, operator mapping, and wildcard normalization).

Verification: Added new unit tests for applyLocalSearchCriteria to tests/utils.test.js and ran the full test suite (npm test). All 388 tests passed, and code coverage for lib/utils.js increased significantly.

Result: Reduced code duplication and provided a clean, reusable helper for filter parsing across the utility module.


PR created automatically by Jules for task 13465693477160819443 started by @cmuench

@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Comment thread lib/utils.js
const shorthand = match[3];
let value = match[4] || '';

let condition = 'eq';
…ilterOption

Co-authored-by: cmuench <211294+cmuench@users.noreply.github.com>
@cmuench cmuench force-pushed the refactor-filter-logic-13465693477160819443 branch from d8aef75 to bf49e92 Compare April 9, 2026 14:01
@cmuench cmuench merged commit e6eb002 into main Apr 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant