🧹 [refactor] extract duplicated filter matching logic#94
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| const shorthand = match[3]; | ||
| let value = match[4] || ''; | ||
|
|
||
| let condition = 'eq'; |
…ilterOption Co-authored-by: cmuench <211294+cmuench@users.noreply.github.com>
d8aef75 to
bf49e92
Compare
🎯 What: Extracted duplicated regex-based filter parsing logic from
buildSearchCriteriaandapplyLocalSearchCriteriainto a new shared helper functionparseFilterOption.💡 Why: This improves maintainability and readability by eliminating code duplication and centralizing filter parsing rules (regex, operator mapping, and wildcard normalization).
✅ Verification: Added new unit tests for
applyLocalSearchCriteriatotests/utils.test.jsand ran the full test suite (npm test). All 388 tests passed, and code coverage forlib/utils.jsincreased significantly.✨ Result: Reduced code duplication and provided a clean, reusable helper for filter parsing across the utility module.
PR created automatically by Jules for task 13465693477160819443 started by @cmuench