Conversation
- Export `toLocalIsoString` and `padDatePart` from `utils/utils.js` for testing. - Add `tests/dateUtils.test.js` with comprehensive test cases. - Use deterministic mocking for timezones in date tests. - Ensure tests run without requiring `jsdom` for independent verification. Co-authored-by: cmuench <211294+cmuench@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
cmuench
deleted the
test-tolocalisostring-improvement-16572052092153190870
branch
1 participant
This PR addresses the testing gap for the
toLocalIsoStringfunction inutils/utils.js.🎯 What:
Added unit tests for
toLocalIsoStringand its helperpadDatePart.📊 Coverage:
The new
tests/dateUtils.test.jscovers:padDatePart: Default padding, custom length, no truncation, and string input.toLocalIsoString: Correct formatting for UTC+0, positive offsets (e.g., UTC+05:30), negative offsets (e.g., UTC-08:00), and millisecond padding.✨ Result:
Improved reliability and coverage of date-related utility functions. The tests are deterministic and independent of the environment's timezone or the presence of
jsdom.PR created automatically by Jules for task 16572052092153190870 started by @cmuench