Skip to content

🔒 [security fix] Replace unsafe innerHTML with replaceChildren() in options.js #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmuench merged 1 commit into from
Apr 5, 2026
Merged

🔒 [security fix] Replace unsafe innerHTML with replaceChildren() in options.js #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 8 additions & 18 deletions options/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,11 @@ const loadWebhooks = async () => {
const normalizedWebhooks = webhooks.map(normalizeWebhookRecord);
const list = document.getElementById("webhook-list");
const message = document.getElementById("no-webhooks-message");
list.innerHTML = "";

// Clear the webhook list safely
while (list.firstChild) {
list.removeChild(list.firstChild);
}
list.replaceChildren();

// Populate group dropdown safely
const groupSelect = document.getElementById("webhook-group");
// Remove all children
while (groupSelect.firstChild) {
groupSelect.removeChild(groupSelect.firstChild);
}
groupSelect.replaceChildren();
const defaultOption = document.createElement("option");
defaultOption.value = "";
defaultOption.selected = true;
Expand Down Expand Up @@ -203,7 +195,7 @@ const loadGroups = async () => {
// Function to render groups in the group management modal
const renderGroups = async () => {
const groups = await loadGroups();
groupsList.innerHTML = "";
groupsList.replaceChildren();

groups.forEach(group => {
const listItem = document.createElement("li");
Expand Down Expand Up @@ -362,9 +354,7 @@ const renderGroups = async () => {
const groupSelect = document.getElementById("webhook-group");
const selectedValue = groupSelect.value;
// Clear existing options
while (groupSelect.firstChild) {
groupSelect.removeChild(groupSelect.firstChild);
}
groupSelect.replaceChildren();

// Create default option using DOM methods instead of innerHTML
const defaultOption = document.createElement("option");
Expand Down Expand Up @@ -684,7 +674,7 @@ customPayloadInput.addEventListener('input', function(e) {

if (matchingVars.length > 0) {
// Show autocomplete dropdown
variablesAutocomplete.innerHTML = '';
variablesAutocomplete.replaceChildren();
variablesAutocomplete.classList.remove('hidden');

matchingVars.forEach(variable => {
Expand Down Expand Up @@ -768,7 +758,7 @@ customPayloadInput.addEventListener('keydown', function(e) {
});

function renderHeaders() {
headersListDiv.textContent = '';
headersListDiv.replaceChildren();
headers.forEach((header, idx) => {
const div = document.createElement('div');
div.style.display = 'flex';
Expand Down Expand Up @@ -867,7 +857,7 @@ function renderSelectors() {
.filter((value) => value.length > 0)
.slice(0, MAX_SELECTORS_PER_WEBHOOK);

selectorsList.textContent = '';
selectorsList.replaceChildren();
updateSelectorsCount();
clearSelectorError();

Expand Down Expand Up @@ -1387,7 +1377,7 @@ document.addEventListener("DOMContentLoaded", () => {
];

function renderEmojiGrid() {
emojiGrid.textContent = '';
emojiGrid.replaceChildren();
EMOJIS.forEach(e => {
const btn = document.createElement('button');
btn.type = 'button';
Expand Down
Loading