Skip to content

[test][accordion] Add axe tests and WCAG conformance reports - #48924

Open
michelengelen wants to merge 2 commits into
mui:masterfrom
michelengelen:a11y/stack/accordion
Open

[test][accordion] Add axe tests and WCAG conformance reports#48924
michelengelen wants to merge 2 commits into
mui:masterfrom
michelengelen:a11y/stack/accordion

Conversation

@michelengelen

@michelengelen michelengelen commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Adds axe coverage and WCAG 2.2 Level A/AA conformance reports for Accordion and AccordionSummary. AccordionDetails/AccordionActions are content containers and do not warrant their own reviews.

Accordion

Result Count
✅ Supports 19
⚠️ Partially Supports 0
❌ Does Not Support 0
➖ Not Applicable 31
↗ Inherited (see AccordionSummary) 5

AccordionSummary

Result Count
✅ Supports 23
⚠️ Partially Supports 1
❌ Does Not Support 0
➖ Not Applicable 31

Known gap: the summary's keyboard-focus indicator is a background tint at ~1.3:1 against paper (1.4.11).

Reports: Accordion/accessibility.md · AccordionSummary/accessibility.md

Important

How to review this PR

Layer 11 of 14 in a stacked series (#48915 → #48926). Its branch is built on a11y/stack/text-field (#48923). GitHub cannot chain PR bases across a fork, so every PR in the series targets master instead.

Review only the last commit — c53a6f9. Everything above it belongs to the layers below, and disappears as those merge.

Original work by @mj12albert. Supersedes #48761, rebased onto current master.

Part of the WCAG conformance effort (#14187).

This was referenced Aug 4, 2026
Open
Closed
@code-infra-dashboard

code-infra-dashboard Bot commented Aug 4, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy preview

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Check out the code infra dashboard for more information about this PR.

@michelengelen michelengelen added test accessibility a11y scope: accordion Changes related to the accordion. labels Aug 5, 2026
@michelengelen
michelengelen force-pushed the a11y/stack/accordion branch 5 times, most recently from 0b570f5 to 345fa27 Compare August 6, 2026 10:43
@michelengelen
michelengelen marked this pull request as ready for review August 7, 2026 10:15
@michelengelen
michelengelen force-pushed the a11y/stack/accordion branch 3 times, most recently from b26c9de to c53a6f9 Compare August 11, 2026 12:25
@michelengelen

michelengelen commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

PR review

No findings.

The slug-wide color-contrast skip is the kind that needs justification, and the in-code comment provides it: the Accordion root's ::before divider blocks axe's background resolution, the rule returns incomplete on some demos, no demo records an actual contrast failure, and the results still land in accordion.a11y.json where drift fails CI. The Accordion/AccordionSummary split (panel semantics vs header button behavior) mirrors the Radio/RadioGroup precedent, and the screenshot opt-out pair for the AccordionA11y* fixtures is ordered correctly.

Residual risk: the two ~300-line conformance reports were spot-checked against the rollup counts, not verified claim by claim.

Verdict

Approve - consistent with the stack template; the one broad assertion skip is well-justified and still recorded.

🤖 Review generated with Claude Code

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 19, 2026
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 26, 2026
@michelengelen @claude
Add the Accordion and AccordionSummary report row
0ef58e2 
Applies mui#48916 (comment):
the shared reports table starts empty, and each component PR appends
its own row.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013HgD6GEW3UxNRvC2abbTy9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silviuaavram silviuaavram Awaiting requested review from silviuaavram
@siriwatknp siriwatknp Awaiting requested review from siriwatknp

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

accessibility a11y scope: accordion Changes related to the accordion. test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michelengelen @mj12albert