chore(core): adopt Nest 12.1 uploads and manage pool shutdown - #2827
Merged
Merged
Conversation
SafeDep Report Summary
No dependency changes detected. Nothing to scan. This report is generated by SafeDep GitHub App |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Innei
force-pushed
the
codex/nest-12-1-upload-pool-lifecycle
branch
from
September 26, 2026 16:50
a5c27a4 to
094e1ed
Compare
- time out pool.end() after 5s instead of blocking app.close() - keep the ended pool cached so late work cannot open a new one - restore disposePool() in the e2e teardown - drop the unreachable InitRestoreGuard - reject disabled comment uploads before quota queries - share the zip upload interceptor and a required-file pipe - add FILE_REQUIRED instead of raw BadRequestException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileInterceptor, preserving upload limits, application error codes, and the initialization check before body parsing. Keep the existing streaming upload paths.app.close(). Register the lifecycle provider in both the server and migration modules, and remove redundant E2E teardown.Verification
pnpm -C apps/core exec vitest run test/src/common/nest-fastify-upload.e2e.spec.ts test/src/modules/file/reader-upload-quota.interceptor.spec.ts test/src/database/postgres-pool-lifecycle.spec.ts(8 tests passed)pnpm -C apps/core run typecheckpnpm -C packages/e2e run typecheckgit diff --checkThe PostgreSQL shutdown tests use a Nest application context with a simulated Pool; a real database shutdown was not exercised in this PR.