feat(aiven-credentials): add activity log GraphQL schema types#363
Merged
feat(aiven-credentials): add activity log GraphQL schema types#363
Conversation
Add GraphQL schema extensions for credential creation activity log entries. Without these, entries were written to the database but would panic if queried via GraphQL. Uses generic naming (CREDENTIALS, not AIVEN_CREDENTIALS) since Aiven is an implementation detail and the types should be reusable for future credential providers.
jhrv
force-pushed
the
fix/aiven-credentials-euthanaisa-label
branch
from
2bace87 to
bc0ed56
Compare
thokra-nav
approved these changes
Mar 17, 2026
Contributor
thokra-nav
left a comment
thokra-nav
left a comment
There was a problem hiding this comment.
Lurer litt på om CREDENTIALS er litt for generisk. Men ser ut som at data typen på sikt kommer til å støtte det meste jeg ser for meg som ikke er Aiven også
Inserts activity log entries via SQL and verifies the GraphQL query returns them correctly with proper type resolution. This is the test that would have panicked before adding the schema types.
Remove Aiven from the public-facing GraphQL schema. 'Aiven' is an implementation detail that end users should not see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AIVEN_CREDENTIALSresource type,AivenCredentialsActivityLogEntrytype, andAIVEN_CREDENTIALS_CREATEactivity filterFollows up on #358 and #362.